odoo/o-spreadsheet#3981
Created by BI, Adrien Minne (adrm)
- label
- odoo:saas-16.3-frozen-pane-page-down-adrm
- head
- eee0c5c56123e8c4de562b8e95831e28a7f6b528
- target
- 16.0
- merged
- 1 month ago by BI, Rémi Rahir (rar)
- forward-ports
- odoo/o-spreadsheet#4047 targeting master
- odoo/o-spreadsheet#4046 targeting saas-17.2
- odoo/o-spreadsheet#4030 targeting saas-17.1
- odoo/o-spreadsheet#4029 targeting 17.0
- odoo/o-spreadsheet#4027 targeting saas-16.4
- odoo/o-spreadsheet#4026 targeting saas-16.3
[FIX] sheetview: pageUp/Down with frozen rows
## Description
There was two issues with the commands `SHIFT_VIEWPORT_UP/DOWN` when some rows were frozen:
- the viewport was never scrolled all the way down to the last row with pageDown
- pageDown/Up scrolled more than a "page" (the size of the viewport)
This commit fixes both issues.
Also replaced calls from `getActiveMainViewport` to `getMainInternalViewport`
in the plugin `SheetView` as it needs slightly less computations.
Task: : [3847414](https://www.odoo.com/web#id=3847414&action=333&active_id=2328&model=project.task&view_type=form&cids=1&menu_id=4720)
## review checklist
- [ ] feature is organized in plugin, or UI components
- [ ] support of duplicate sheet (deep copy)
- [ ] in model/core: ranges are Range object, and can be adapted (adaptRanges)
- [ ] in model/UI: ranges are strings (to show the user)
- [ ] undo-able commands (uses this.history.update)
- [ ] multiuser-able commands (has inverse commands and transformations where needed)
- [ ] new/updated/removed commands are documented
- [ ] exportable in excel
- [ ] translations (\_t("qmsdf %s", abc))
- [ ] unit tested
- [ ] clean commented code
- [ ] track breaking changes
- [ ] doc is rebuild (npm run doc)
- [ ] status is correct in Odoo