odoo/enterprise#76460
Created by BI, Lucas Lefèvre (lul)
Merged
at adbc8887bfe47271a15a8255ae3cced91cd76c3f
Statuses:
- legal/cla: Contributor License Agreement check
- ci/runbot: Odoo Test Suite
- ci/upgrade_enterprise: Test upgrades for enterprise master
- ci/template: Contact runbot team on discord for help.
- ci/style: Optional style check. Ignore it only if strictly necessary.
- ci/security: Required security check. Can only be ignored by security team.
- ci/l10n: (runtime 0s)
Linked pull requests
- label
- odoo-dev:18.0-disable-download-live-shared-spreadsheet-lul
- head
- eb17cc511cebe77f9aabdc385337de0ffd416da5
- merged
- 7 months ago by BI, Pierre Rousseau (pro)
| odoo/odoo | odoo/enterprise | |
|---|---|---|
| 18.0 | #192349 | #76460 |
| saas-18.1 | #194137 | #77343 |
| saas-18.2 | ||
| saas-18.3 | ||
| saas-18.4 | ||
| master | #194163 | #77358 |
[FIX] documents_spreadsheet: disable public download button
Steps to reproduce:
- install Documents
- create a new spreadsheet
- hit the Share button
- change the sharing settings to "Anyone with the link: Viewer / Musty have the link to access"
- open the sharing link in an incognito window
- hit the download button
=> 404 not found
A public user cannot convert a spreadsheet to an excel file and downlaod it because a route needs to be called to create the excel file. This route is currently not allowed for public users.
For frozen spreadsheet, we generate the excel file before-hand (when the internal user shares the spreadsheet). For a regular "live" share though, we cannot pre-generate the excel file since the spreadsheet continues to live and evolve.
The spreadsheet module needs to be updated for this bug fix to take effect. (otherwise the download button won't do anything, which is not worse than facing a 404 response)
See also community PR.