odoo/enterprise#82795

Created by fw-bot

label

odoo-dev:saas-18.2-17.0-opw-4480104-barcode_qc_extra-lase-426866-fw

head

3ce707a2ffe2b0373dcaa652cabdb9153ab7f4a5

merged

6 months ago by Bugfix, Lancelot Semal (lase)

	odoo/odoo	odoo/enterprise
17.0	#202725	#81850
saas-17.4	#202859	#81903
18.0	#203662	#82291
saas-18.1	#204255	#82643
saas-18.2	#204584	#82795
saas-18.3
saas-18.4
19.0
master	#204602	#82802

[FW][FIX] *: ensure creation of quality checks

• stock{,_barcode, _barcode_quality_control}, quality_control

Issue:

Quality checks per operation and per product are generated by an override of the action confirm of the move. However, if a move line is created on a non draft picking, it will end up in a move that will never be confirmed. This happends because the move is created with a state to match its already existing picking and hence is not confirmed at creation and since only draft pickings are confirmed at the start of the button validate. As a result, we will not create the quality checks related to these additional moves.

The above issue can be triggered in many situations. Here are the two major ones:

Use case I:

Creating a delivery or an internal transfer on the fly from the barcode app.

Steps to reproduce:

• Create a storable product P with a barcode: XXX
• Go to Quality > Quality Control > Quality Points > New
• Create a new quality point for your product: Control per: "Operation" Operations: "Delivery"
• Go to the barcode app > Operations > Delivery > New
• Scan your product
• Validate the Delivery

> the picking is done but no QC was created nor processed.

Cause of the issue:

The save_barcode_data will launch the creation of the move line related to the barcode line you edited from the barcode app. During the create of this 'stock.move.line', an associated move will be created and its initial "state" will be the current state of the picking: https://github.com/odoo/odoo/blob/ba799a020dd2b07c9d6c379e23acee1e6fcc5e0a/addons/stock/models/stock_move_line.py#L354-L356 https://github.com/odoo/odoo/blob/ba799a020dd2b07c9d6c379e23acee1e6fcc5e0a/addons/stock/models/stock_move_line.py#L942 At this point the picking state is "draft" and the move will be correctly created in draft. However, just a few lines after its creation, we will check if a reservation should be done with that move and if its state should be recomputed:
https://github.com/odoo/odoo/blob/ba799a020dd2b07c9d6c379e23acee1e6fcc5e0a/addons/stock/models/stock_move_line.py#L379-L396 the discrepancy is caused by the fact that move._should_bypass_reservation will be true if the picking is a receipt and false for the other types because you should bypass reservation for moves whose source is not an internal location but you should not for others. This will leave the moves and picking in draft state if its a receipt and update it for other types. However, only draft pickings are confirmed at the beginning of the button validate: https://github.com/odoo/odoo/blob/b0cfeecacfc6b95659778dfe4d62435556aaa92c/addons/stock/models/stock_picking.py#L1131-L1133

Use case II:

Create and confirm a picking of any type so that it ends up being assigned. Add manually a move line via the detailed operations.

Steps to reproduce:

• Create two storable product P1 and P2 put 10 units of both in stock
• Go to Quality > Quality Control > Quality Points > New
• Create a new quality point for your product P2: Control per: "Operation" Operations: "Delivery"
• Create and confirm a Delivery for 1 unit P1
• Go to Detailed Operations > create a new line for 1 unit of P2
• Validate the Delivery

> the picking is done but no QC was created nor processed.

Cause of the issue:

For the same reasons as above, the newly created move is assigned as it mimics the state of the current picking which is assigned since we have already reserved the already existing move.

Fix:

We ensure the creation of quality checks for moves that end up being created but will never be confirmed.

Technical limitation:

Unfortunately, it is not possible to manage the use case of quality checks related the component of a kit product without disrupting the barcode flows. Indeed, in barcode flows, the move line as well as its related move is created by a save_barcode_data. If we were to confirm the newly created moves rather than just trying to create the QC, it would indeed first explode the bom and then create the related QC for each component. However, the barcode data would not coincide anymore with the back end data since the line we just saved would have been exploded at backend creation. For that reason we do not yet support the above use cases for kit products.

Community: odoo/odoo#202725

opw-4480104

Forward-Port-Of: #82643
Forward-Port-Of: #81850