odoo/o-spreadsheet#3856

Created by Website, Julien Launois (jula)

label

odoo:17.0-export-export-non-Excel-formulas-as-value-jula

head

fb0400d9def19564cab55547595497657f6fab5d

merged

3 years ago by BI, Vincent Schippefilt (vsc)

[FIX] export: export non-Excel formulas as value

Current behavior before commit:
Since the commit 201aea7, when formulaCell is a FormulaCellWithDependencies, content might be set to raw formula even if it is not readable by Excel.

Description of the fix:
Prevent content to be set to the raw formula if isFormula === false.

Example of steps to reproduce the issue:
- Write a number in A1
- Write =FORMAT.LARGE.NUMBER(A1) in A2
- Save as XLSX and open in Excel -> A2 is not evaluated by Excel

opw-3782676

review checklist

• [ ] feature is organized in plugin, or UI components
• [ ] support of duplicate sheet (deep copy)
• [ ] in model/core: ranges are Range object, and can be adapted (adaptRanges)
• [ ] in model/UI: ranges are strings (to show the user)
• [ ] undo-able commands (uses this.history.update)
• [ ] multiuser-able commands (has inverse commands and transformations where needed)
• [ ] new/updated/removed commands are documented
• [ ] exportable in excel
• [ ] translations (_t("qmsdf %s", abc))
• [ ] unit tested
• [ ] clean commented code
• [ ] track breaking changes
• [ ] doc is rebuild (npm run doc)
• [ ] status is correct in Odoo