odoo/o-spreadsheet#4250
Created by BI, Mehdi Rachico (mera)
Merged
at af15d3af3ec411e94a2954df0efac3c0fdc7b0ed
Statuses:
- label
- odoo:saas-17.2-fix-previous-find-and-replace-mera
- head
- 4b733842b9fc0cb26826af571b7ed91b58791ca4
- merged
- 4 months ago by BI, Pierre Rousseau (pro)
odoo/o-spreadsheet | |
---|---|
saas-17.2 | #4250 |
saas-17.3 | #4508 |
master | #4511 |
[FIX] find_and_replace: fix previous command
[FIX] find_and_replace: fix previous command
Problem
The problem occurs when we perform a search using "Find & Replace". In fact, when going backward to a previous occurrence that is located in the previous sheet, we match the first occurrence of that sheet, when actually we need to match on the last occurrence of that sheet.
Solution
This commit solves the issue by checking whether the sheet switch is automatic (coming from the Previous button).
Task: 3839575
review checklist
- [ ] feature is organized in plugin, or UI components
- [ ] support of duplicate sheet (deep copy)
- [ ] in model/core: ranges are Range object, and can be adapted (adaptRanges)
- [ ] in model/UI: ranges are strings (to show the user)
- [ ] undo-able commands (uses this.history.update)
- [ ] multiuser-able commands (has inverse commands and transformations where needed)
- [ ] new/updated/removed commands are documented
- [ ] exportable in excel
- [ ] translations (_t("qmsdf %s", abc))
- [ ] unit tested
- [ ] clean commented code
- [ ] track breaking changes
- [ ] doc is rebuild (npm run doc)
- [ ] status is correct in Odoo
-
https://github.com/wkhtmltopdf/packaging/releases ↩