odoo/o-spreadsheet#4325
Created by Mehdi Rachico (mera)
Merged
at 58cd608e268bd1515a725f282c89d49e4a3c1e47
Statuses:
- label
- odoo:15.0-wrong-borders-removed-on-delete-rows-mera
- head
- 3c5924e2f441e6390112b9a3dc51e9437ee2b382
- merged
- 2 years ago by BI, Rémi Rahir (rar)
| odoo/o-spreadsheet | |
|---|---|
| 15.0 | #4325 |
| 16.0 | #4527 |
| 17.0 | #4603 |
| saas-17.1 | #4604 |
| 18.0 | |
| saas-17.2 | #4605 |
| saas-17.3 | #4606 |
| saas-18.2 | |
| saas-18.3 | |
| saas-18.4 | |
| 19.0 | |
| saas-19.1 | |
| saas-19.2 | |
| saas-19.3 | |
| master | #4607 |
[FIX] border: bottom sheet borders removed on DELETE_ROWS
[FIX] border: bottom sheet borders removed on DELETE_ROWS
Problem
Before this commit, when we add borders at the bottom of a sheet (at very the last rows), if we delete some rows in a position before the borders, some/all borders disappear (depending on how many rows we deleted). The reason being that the sheet plugin updates the total rows before we loop through them to shift the borders.
Solution
This commit fixes this behaviour by redefining the way we get the border to shift.
Task: 3911695
review checklist
- [ ] feature is organized in plugin, or UI components
- [ ] support of duplicate sheet (deep copy)
- [ ] in model/core: ranges are Range object, and can be adapted (adaptRanges)
- [ ] in model/UI: ranges are strings (to show the user)
- [ ] undo-able commands (uses this.history.update)
- [ ] multiuser-able commands (has inverse commands and transformations where needed)
- [ ] new/updated/removed commands are documented
- [ ] exportable in excel
- [ ] translations (_t("qmsdf %s", abc))
- [ ] unit tested
- [ ] clean commented code
- [ ] track breaking changes
- [ ] doc is rebuild (npm run doc)
- [ ] status is correct in Odoo