odoo/o-spreadsheet#4515

Created by BI, Pierre Rousseau (pro)
Merged at 97535323a5d9681e8fadb264d30afdc665ead6ef

Statuses:

label
odoo:saas-17.3-fw-pivot-position-pro
head
1362eafeed7cf26f48a38bd16ede6978a4c5706d
merged
4 months ago by BI, Lucas Lefèvre (lul)
odoo/o-spreadsheet
saas-17.3 #4515
master #4516

[FIX] spreadsheet: correctly get pivot id from position

Steps to reproduce in 17.0:

There's no way to reproduce the issue in 17.0 because the faulty getter in only called on positions in the active sheet (pivot autofill, global filter auto-matching)

Steps to reproduce in saas-17.1:

  • insert a pivot in a blank spreadsheet
  • delete all pivot formulas
  • insert a new sheet
  • in the new sheet:
    • in A1: type "1"
    • in A2: =ODOO.PIVOT(A1)
  • activate the first sheet again
  • Open the Data menu => the pivot 1 is marked as being unused, even though it's used in the second
    sheet

task-3859472
X-original-commit: odoo/odoo@0f9161ebc3589678fea5a0b242b00c01b8df2725

Description:

description of this task, what is implemented and why it is implemented that way.

Task: : TASK_ID

review checklist

  • [ ] feature is organized in plugin, or UI components
  • [ ] support of duplicate sheet (deep copy)
  • [ ] in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • [ ] in model/UI: ranges are strings (to show the user)
  • [ ] undo-able commands (uses this.history.update)
  • [ ] multiuser-able commands (has inverse commands and transformations where needed)
  • [ ] new/updated/removed commands are documented
  • [ ] exportable in excel
  • [ ] translations (_t("qmsdf %s", abc))
  • [ ] unit tested
  • [ ] clean commented code
  • [ ] track breaking changes
  • [ ] doc is rebuild (npm run doc)
  • [ ] status is correct in Odoo