odoo/o-spreadsheet#4520
Created by BI, Dhrutik Patel (dhrp)
Merged
at 47d8c56883178ee7c9a8856c685f3e405add74ec
Statuses:
- label
- odoo:master-fix-chart-title-again-dhrp
- head
- e53c3cae8437a603f5d07516c55cda771f9c26a3
- merged
- 3 months ago by BI, Adrien Minne (adrm)
odoo/o-spreadsheet | |
---|---|
master | #4520 |
[FIX] ChartTitle: traceback when chart title is undefined
Description:
With my recent PR#4476, creating a chart from scratch via the top menu item results in the chart title being undefined. This causes a traceback in the side panel since the ChartTitle component expects the title prop to be a string.
Task: : TASK_ID
review checklist
- [ ] feature is organized in plugin, or UI components
- [ ] support of duplicate sheet (deep copy)
- [ ] in model/core: ranges are Range object, and can be adapted (adaptRanges)
- [ ] in model/UI: ranges are strings (to show the user)
- [ ] undo-able commands (uses this.history.update)
- [ ] multiuser-able commands (has inverse commands and transformations where needed)
- [ ] new/updated/removed commands are documented
- [ ] exportable in excel
- [ ] translations (_t("qmsdf %s", abc))
- [ ] unit tested
- [ ] clean commented code
- [ ] track breaking changes
- [ ] doc is rebuild (npm run doc)
- [ ] status is correct in Odoo