odoo/o-spreadsheet#4615
Created by fw-bot
Merged
at 81381a4254edb070750a96be4664e3d02824704f
Statuses:
- label
- odoo:saas-17.2-17.0-chart-not-updating-adrm-XTR2-fw
- head
- 5e753354650f14aa5761b5f62e9c9dfc4d4a8cf6
- merged
- 2 years ago by BI, Adrien Minne (adrm)
| odoo/o-spreadsheet | |
|---|---|
| 17.0 | #4572 |
| saas-17.1 | #4602 |
| 18.0 | |
| saas-17.2 | #4615 |
| saas-17.3 | #4616 |
| saas-18.2 | |
| saas-18.3 | |
| saas-18.4 | |
| 19.0 | |
| saas-19.1 | |
| saas-19.2 | |
| saas-19.3 | |
| master | #4617 |
[FW][REV] chart: avoid useless chart updates
Description
This reverts commit 6eb43533d.
It turns out that checking the deep equality of runtime while ignoring functions is not a good fix to avoid useless chart updates. The problem is that some runtime changes apply only to the callbacks (eg. changing the dataset format only change the ticks callback).
The only real alternative would be to add the variables that are used in the callbacks to the runtime, so the deepEquals would work. But this is very error prone: we'll 100% forget to add a variable at some point.
So we will accept the useless updates for now, until we see a real performance issue.
Task: : 4029016
review checklist
- [ ] feature is organized in plugin, or UI components
- [ ] support of duplicate sheet (deep copy)
- [ ] in model/core: ranges are Range object, and can be adapted (adaptRanges)
- [ ] in model/UI: ranges are strings (to show the user)
- [ ] undo-able commands (uses this.history.update)
- [ ] multiuser-able commands (has inverse commands and transformations where needed)
- [ ] new/updated/removed commands are documented
- [ ] exportable in excel
- [ ] translations (_t("qmsdf %s", abc))
- [ ] unit tested
- [ ] clean commented code
- [ ] track breaking changes
- [ ] doc is rebuild (npm run doc)
- [ ] status is correct in Odoo