odoo/o-spreadsheet#5075

Created by fw-bot
Merged at ae35d0339f46467a91695f3243ec22be34a164df

Statuses:

label
odoo:master-saas-17.4-divergent-duplicated-pivot-name-lul-noGU-fw
head
54ed61e702550c6ccdafcf3246a215d02bb42368
merged
1 year ago by BI, Rémi Rahir (rar)
odoo/o-spreadsheet
saas-17.4 #5010
18.0 #5074
saas-18.2
saas-18.3
saas-18.4
19.0
saas-19.1
master #5075

[FW][FIX] pivot: divergent collaborative duplicated pivot name

Description:

Currently, if two users are connected to the same spreadsheet, both have
different languages and one of them duplicates a pivot: the spreadsheet
states have diverged because _t(...) gives two different results on both
sides.

Note that the command should ideally be upgraded with a script, but it's
not possible to get the original pivot name on the upgrade platform.
Task: 4199949

review checklist

  • [ ] feature is organized in plugin, or UI components
  • [ ] support of duplicate sheet (deep copy)
  • [ ] in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • [ ] in model/UI: ranges are strings (to show the user)
  • [ ] undo-able commands (uses this.history.update)
  • [ ] multiuser-able commands (has inverse commands and transformations where needed)
  • [ ] new/updated/removed commands are documented
  • [ ] exportable in excel
  • [ ] translations (_t("qmsdf %s", abc))
  • [ ] unit tested
  • [ ] clean commented code
  • [ ] track breaking changes
  • [ ] doc is rebuild (npm run doc)
  • [ ] status is correct in Odoo

Forward-Port-Of: #5010