odoo/o-spreadsheet#5252

Created by BI, Adrien Minne (adrm)

label

odoo:18.0-composer-assistant-overflow-adrm

head

5257103b96dffd6ddc7340d516518093cb08af63

merged

5 days ago by BI, Rémi Rahir (rar)

	odoo/o-spreadsheet
18.0	#5252
master	#5255

[FIX] composer: overflow on composer at end of screen

Description

The button to close the composer's formula assistant would overflow for the viewport and make an additional scrollbar appear when it's at the end of the screen (eg. standalone composer in the CF color scale panel).

This was due to two things:
1) there was a comment with //, which is invalid css and disabled the width property of the button
2) we were using a CLOSE_ICON_RADIUS to compute the position of the formula assistant. But this constant wasn't actually used in the CSS, so the button could have an arbitrary width unrelated to the constant. (in practice it was 18.4px vs 18px, but this would change if we changed the font size).

Task: 4315958

review checklist

• [ ] feature is organized in plugin, or UI components
• [ ] support of duplicate sheet (deep copy)
• [ ] in model/core: ranges are Range object, and can be adapted (adaptRanges)
• [ ] in model/UI: ranges are strings (to show the user)
• [ ] undo-able commands (uses this.history.update)
• [ ] multiuser-able commands (has inverse commands and transformations where needed)
• [ ] new/updated/removed commands are documented
• [ ] exportable in excel
• [ ] translations (_t("qmsdf %s", abc))
• [ ] unit tested
• [ ] clean commented code
• [ ] track breaking changes
• [ ] doc is rebuild (npm run doc)
• [ ] status is correct in Odoo