odoo/o-spreadsheet#5254

Created by fw-bot

label

odoo:master-18.0-early-error-return-lul-hPjX-fw

head

af1f27033d72f1bd68055aa3502dcb09d0ababb6

merged

1 day ago by BI, Lucas Lefèvre (lul)

	odoo/o-spreadsheet
18.0	#5163
master	#5254

[FW][PERF] evaluation: early return errors

Description:

Throwing errors is super slow but the evaluation uses throw in many
places when the formula result is an error (historic). Returning
the error result is better than throwing.

Extensive work has been done in the past year to reduce throw, especially
the "Loading..." errors.

But if a function receives an error object as an argument and the
function uses one of the casting helpers (toNumber, toString, etc.)
the error is still thrown.

With this commit, if a function argument is an error, we by pass the
function compute and the error is directly returned.

That is unless the argument is declared as accepting the type any,
in which case it can use the error argument as part of its business logic.

We currently only check simple scalar arguments (and not matrices) for
performance reasons. Iterating over all matrices to check if there's any
error is costly and probably outweights the benefits (especially when there
isn't any error)

On one of the dashboard on odoo.com (id=116), the evaluation triggered by
setting a global filter is reduced by ~70% (when setting a filter,
everything is reloading and hence there are "Loading..." everywhere

before: 1707ms
after: 533ms

There's no significant performance hit on regular evaluations (when there's
no errors)

Many types of many function arguments had to be changed to remove any
where the function doesn't need to handle errors itself.

For some function expecting an matrix of a given type (let's say
range<number>), we added range<any>. The real type of those arguments
is range<any> but from a functional POV, they expect range<number> and
ignore any other values. We leave the range<number> only for an informative
reason.

Task: 4328215

review checklist

• [ ] feature is organized in plugin, or UI components
• [ ] support of duplicate sheet (deep copy)
• [ ] in model/core: ranges are Range object, and can be adapted (adaptRanges)
• [ ] in model/UI: ranges are strings (to show the user)
• [ ] undo-able commands (uses this.history.update)
• [ ] multiuser-able commands (has inverse commands and transformations where needed)
• [ ] new/updated/removed commands are documented
• [ ] exportable in excel
• [ ] translations (_t("qmsdf %s", abc))
• [ ] unit tested
• [ ] clean commented code
• [ ] track breaking changes
• [ ] doc is rebuild (npm run doc)
• [ ] status is correct in Odoo

Forward-Port-Of: #5163