odoo/o-spreadsheet#5446
Created by fw-bot
Merged
at abb81f0ac8668f966c0f5e1801b05a27f82d2f17
Statuses:
- label
- odoo:master-18.0-snapshot-when-open-xlsx-mera-uS5O-fw
- head
- 83dde56a8c2808e0b7e64a3d4d0414b7181ae2dc
- merged
- 1 year ago by Mehdi Rachico (mera)
| odoo/o-spreadsheet | |
|---|---|
| 18.0 | #5320 |
| saas-18.1 | #5445 |
| saas-18.2 | |
| saas-18.3 | |
| saas-18.4 | |
| 19.0 | |
| saas-19.1 | |
| saas-19.2 | |
| saas-19.3 | |
| master | #5446 |
[FW][IMP] model: create snapshot when loading xlsx file
Before this commit, when uploading an XLSX file, the code in the Odoo repository would create a spreadsheet document with data that is encoded in xml. Whenever the file is loaded, we parse the stringified xml to convert it to the o-spreadsheet json structure. The problem is that this conversion can be quite slow and costly when the XLSX file is large.
This commit mitigates the issue by saving a snapshot once the XLSX file is loaded for the first time.
Task: 4080514
review checklist
- [ ] feature is organized in plugin, or UI components
- [ ] support of duplicate sheet (deep copy)
- [ ] in model/core: ranges are Range object, and can be adapted (adaptRanges)
- [ ] in model/UI: ranges are strings (to show the user)
- [ ] undo-able commands (uses this.history.update)
- [ ] multiuser-able commands (has inverse commands and transformations where needed)
- [ ] new/updated/removed commands are documented
- [ ] exportable in excel
- [ ] translations (_t("qmsdf %s", abc))
- [ ] unit tested
- [ ] clean commented code
- [ ] track breaking changes
- [ ] doc is rebuild (npm run doc)
- [ ] status is correct in Odoo
Forward-Port-Of: #5320