odoo/o-spreadsheet#5587
Created by fw-bot
Merged
at 79e6457ce53f2d4157e0cbfc89c3c81c7d9dbe0e
Statuses:
- label
- odoo:saas-18.1-17.0-locale-number-parsing-fix-adrm-YrpW-fw
- head
- c6fb2e887333ec75d4f97948fb96f3a394d8d661
- merged
- 6 months ago by BI, Pierre Rousseau (pro)
| odoo/o-spreadsheet | |
|---|---|
| 17.0 | #5573 |
| saas-17.4 | #5585 |
| 18.0 | #5586 |
| saas-17.2 | #5583 |
| saas-18.1 | #5587 |
| saas-18.2 | |
| saas-18.3 | |
| saas-18.4 | |
| master | #5588 |
[FW][FIX] locale: wrong parsing with "." thousand separator
Description
The parsing of strings to number was wrong if the thousand separator was a ".". We would first replace the locale's thousand separator with JS's thousand separator ("."), and then remove all thousand separators in the string. Thus removing the actual decimal separator.
Task: 4525746
review checklist
- [ ] feature is organized in plugin, or UI components
- [ ] support of duplicate sheet (deep copy)
- [ ] in model/core: ranges are Range object, and can be adapted (adaptRanges)
- [ ] in model/UI: ranges are strings (to show the user)
- [ ] undo-able commands (uses this.history.update)
- [ ] multiuser-able commands (has inverse commands and transformations where needed)
- [ ] new/updated/removed commands are documented
- [ ] exportable in excel
- [ ] translations (_t("qmsdf %s", abc))
- [ ] unit tested
- [ ] clean commented code
- [ ] track breaking changes
- [ ] doc is rebuild (npm run doc)
- [ ] status is correct in Odoo