odoo/o-spreadsheet#5734

Created by BI, Adrien Minne (adrm)

label

odoo:master-fix-selection-input-reorder-colors-adrm

head

692eb20b1417925ea2c4b726e037c6f3684526af

merged

1 year ago by BI, Rémi Rahir (rar)

[FIX] selection input: highlight color not sync with range color

Description

After re-ordering the selection inputs of a chart, the highlight colors would not be the same as the range colors.

This was because the store mutator updateColors would not update the store range colors. And store.highlights is based on ranges.colors while store.selectionInputs ignores the colors of store.ranges.

The test update of colors are taken into account was also a bit sketchy. We would modify the props.colors array in place, thus the condition nextProps.colors !== props.colors would never be satisfied, and store.updateColors would never be called.

Task: 4577803

review checklist

• [ ] feature is organized in plugin, or UI components
• [ ] support of duplicate sheet (deep copy)
• [ ] in model/core: ranges are Range object, and can be adapted (adaptRanges)
• [ ] in model/UI: ranges are strings (to show the user)
• [ ] undo-able commands (uses this.history.update)
• [ ] multiuser-able commands (has inverse commands and transformations where needed)
• [ ] new/updated/removed commands are documented
• [ ] exportable in excel
• [ ] translations (_t("qmsdf %s", abc))
• [ ] unit tested
• [ ] clean commented code
• [ ] track breaking changes
• [ ] doc is rebuild (npm run doc)
• [ ] status is correct in Odoo