odoo/o-spreadsheet#6210

Created by BI, Adrien Minne (adrm)

label

odoo:saas-18.3-fix-compile-types-adrm

head

f31823e956a4a337ea91d1c1b8506284e8e2e372

merged

1 month ago by BI, Pierre Rousseau (pro)

	odoo/o-spreadsheet
saas-18.3	#6210
master	#6259

[FIX] ts: fix compiling of `.d.ts` files

It wasn't possible to compile the lib into .d.ts since 8a02a6b, error ... exported class expression may not be private or protected.[1]

It seems that we cannot have an anonymous class with private/protected methods. We had a similar issue with the PivotPresentationLayer.

This commit adds explicit typing to the functions generating the funnel chart classes, so typescript doesn't try to infer types for them.

[1]: see microsoft/TypeScript#30355 or microsoft/TypeScript#36060

task-0

Description:

description of this task, what is implemented and why it is implemented that way.

Task: TASK_ID

review checklist

• [ ] feature is organized in plugin, or UI components
• [ ] support of duplicate sheet (deep copy)
• [ ] in model/core: ranges are Range object, and can be adapted (adaptRanges)
• [ ] in model/UI: ranges are strings (to show the user)
• [ ] undo-able commands (uses this.history.update)
• [ ] multiuser-able commands (has inverse commands and transformations where needed)
• [ ] new/updated/removed commands are documented
• [ ] exportable in excel
• [ ] translations (_t("qmsdf %s", abc))
• [ ] unit tested
• [ ] clean commented code
• [ ] track breaking changes
• [ ] doc is rebuild (npm run doc)
• [ ] status is correct in Odoo