odoo/o-spreadsheet#6335

Created by BI, Adrien Minne (adrm)
Merged at 82ddf50a215456dc2a980f747b5444d894998988

Statuses:

label
odoo:saas-17.4-pivot-month-granularity-sorting-adrm
head
ccb15cc379f09e0f19b03cf01183014499840786
merged
2 weeks ago by BI, Lucas Lefèvre (lul)
odoo/o-spreadsheet
saas-17.4 #6335
18.0 #6436
saas-18.1 #6486
saas-18.2 #6487
saas-18.3 #6488
master #6489

[FIX] pivot: `month` granularity sorting

Description

The month granularity sorting wasn't working. The issue was that we were using Number(value) instead of toNumber(value) to convert the field value to a number.

Task: 4781810

review checklist

  • [ ] feature is organized in plugin, or UI components
  • [ ] support of duplicate sheet (deep copy)
  • [ ] in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • [ ] in model/UI: ranges are strings (to show the user)
  • [ ] undo-able commands (uses this.history.update)
  • [ ] multiuser-able commands (has inverse commands and transformations where needed)
  • [ ] new/updated/removed commands are documented
  • [ ] exportable in excel
  • [ ] translations (_t("qmsdf %s", abc))
  • [ ] unit tested
  • [ ] clean commented code
  • [ ] track breaking changes
  • [ ] doc is rebuild (npm run doc)
  • [ ] status is correct in Odoo