odoo/o-spreadsheet#6783
Created by Ronakkumar Mukeshbhai Bharadiya (rmbh)
- label
- odoo:saas-18.4-fix-reopen-sidepanel-from-child-rmbh
- head
- 98b51445b6f324e10702967741e49dea8b6ae3c7
| odoo/o-spreadsheet | |
|---|---|
| saas-18.4 | #6783 missing r+ |
| master |
[FIX] side_panel: replace side panel instead of stacking it
Description:
Steps to reproduce:
- Open the global filter side panel (list of all filters)
- Pin the panel
- Click on a specific filter to view/edit it
Current behavior before PR:
- A second side panel was opened instead of replacing the current one
- Clicking 'Cancel' on the new panel had no effect
- Clicking 'Remove' caused a traceback
Desired behavior after PR is merged:
- The new side panel replaces the current one (main or secondary)
- The previous panel is restored correctly on 'Cancel' or 'Remove'
- If the new panel is already open, we simply close the current one
Task: 4911603
review checklist
- [ ] feature is organized in plugin, or UI components
- [ ] support of duplicate sheet (deep copy)
- [ ] in model/core: ranges are Range object, and can be adapted (adaptRanges)
- [ ] in model/UI: ranges are strings (to show the user)
- [ ] undo-able commands (uses this.history.update)
- [ ] multiuser-able commands (has inverse commands and transformations where needed)
- [ ] new/updated/removed commands are documented
- [ ] exportable in excel
- [ ] translations (_t("qmsdf %s", abc))
- [ ] unit tested
- [ ] clean commented code
- [ ] track breaking changes
- [ ] doc is rebuild (npm run doc)
- [ ] status is correct in Odoo