odoo/o-spreadsheet#6920

Created by fw-bot

label

odoo:saas-18.3-18.0-fix-offset-dependency-rar-455911-fw

head

5f3d13a3a3b3ceb5fe259b26aa3143258817f6bf

merged

1 month ago by BI, Lucas Lefèvre (lul)

	odoo/o-spreadsheet
18.0	#6909
saas-18.1	#6918
saas-18.2	#6919
saas-18.3	#6920
saas-18.4	#6921
19.0
master	#6922

[FIX] Functions: OFFSET dependencies are not correctly added

OFFSET is part of the formulas which depednencies need to be dynamically added during its evaluation by interpreting their arguments. Unfortunately, the implementation was wrongly mistakenly assigning the dependency to the sheet of the currently evaluated cell instead of the the sheetId of the actual cell reference.

task-5001405

Description:

description of this task, what is implemented and why it is implemented that way.

Task: TASK_ID

review checklist

• [ ] feature is organized in plugin, or UI components
• [ ] support of duplicate sheet (deep copy)
• [ ] in model/core: ranges are Range object, and can be adapted (adaptRanges)
• [ ] in model/UI: ranges are strings (to show the user)
• [ ] undo-able commands (uses this.history.update)
• [ ] multiuser-able commands (has inverse commands and transformations where needed)
• [ ] new/updated/removed commands are documented
• [ ] exportable in excel
• [ ] translations (_t("qmsdf %s", abc))
• [ ] unit tested
• [ ] clean commented code
• [ ] track breaking changes
• [ ] doc is rebuild (npm run doc)
• [ ] status is correct in Odoo

Forward-Port-Of: #6909