odoo/o-spreadsheet#7146
Created by BI, Dhrutik Patel (dhrp)
Merged
at 5395a3b621af9b170451c04d72c191f14bc294e5
Statuses:
- label
- odoo:17.0-fix-dv-multi-sheet-range-selection-dhrp
- head
- b164b1b139d69bdc4ab3fe2c7bbbf9e7289e1e04
- merged
- 2 months ago by BI, Lucas Lefèvre (lul)
| odoo/o-spreadsheet | |
|---|---|
| 17.0 | #7146 |
| 18.0 | #7319 |
| saas-18.2 | #7322 |
| saas-18.3 | #7323 |
| saas-18.4 | #7324 |
| 19.0 | #7328 |
| master | #7329 |
[FIX] data_validation: selecting range from another sheet
Description:
Steps to reproduce:
- Create a new sheet (Sheet2).
- On Sheet1, open the Data Validation side panel.
- Add a DV with type "isValueInRange".
- Click on the selection input to select the range.
- Navigate to Sheet2 and select the range.
- Click on Save without confirming the ranges.
Before this PR:
- The DV was created on Sheet2 instead of remaining on Sheet1.
After this PR:
- The DV is correctly created on the original sheet (Sheet1).
Task: 4948201
review checklist
- [ ] feature is organized in plugin, or UI components
- [ ] support of duplicate sheet (deep copy)
- [ ] in model/core: ranges are Range object, and can be adapted (adaptRanges)
- [ ] in model/UI: ranges are strings (to show the user)
- [ ] undo-able commands (uses this.history.update)
- [ ] multiuser-able commands (has inverse commands and transformations where needed)
- [ ] new/updated/removed commands are documented
- [ ] exportable in excel
- [ ] translations (_t("qmsdf %s", abc))
- [ ] unit tested
- [ ] clean commented code
- [ ] track breaking changes
- [ ] doc is rebuild (npm run doc)
- [ ] status is correct in Odoo