odoo/o-spreadsheet#7384

Created by BI, Adrien Minne (adrm)

label

odoo:master-fix-pivot-design-panel-adrm

head

1f3ae7043c3d249a66de44c14c758b7d55382e57

merged

2 months ago by BI, Lucas Lefèvre (lul)

	odoo/o-spreadsheet
master	#7384

[FIX] pivot: error on removing max number of columns/rows

Description

When deleting the pivot style numberOfRows or numberOfColumns in the pivot design panel, the pivot would be in error. This was because we didn't handle the cases where the content on the input was not a number, and would set NaN values.

Task: 5220970

review checklist

• [ ] feature is organized in plugin, or UI components
• [ ] support of duplicate sheet (deep copy)
• [ ] in model/core: ranges are Range object, and can be adapted (adaptRanges)
• [ ] in model/UI: ranges are strings (to show the user)
• [ ] undo-able commands (uses this.history.update)
• [ ] multiuser-able commands (has inverse commands and transformations where needed)
• [ ] new/updated/removed commands are documented
• [ ] exportable in excel
• [ ] translations (_t("qmsdf %s", abc))
• [ ] unit tested
• [ ] clean commented code
• [ ] track breaking changes
• [ ] doc is rebuild (npm run doc)
• [ ] status is correct in Odoo