odoo/o-spreadsheet#7482
Created by fw-bot
Merged
at 06263d9c0bbb442050dbd64ff9eb8d3e2a4c55ce
Statuses:
- label
- odoo:master-18.0-close-side-panel-on-dup-chart-rar-478259-fw
- head
- 29aa2f76f9d36881e653ee21ff3e5357dd68fd0c
- merged
- 3 days ago by BI, Rémi Rahir (rar)
| odoo/o-spreadsheet | |
|---|---|
| 18.0 | #7184 |
| saas-18.2 | #7476 |
| saas-18.3 | #7478 |
| saas-18.4 | #7480 |
| 19.0 | #7481 |
| master | #7482 |
[FIX] SidePanel: reset initial props on model change
Currently, we store the initial props with which the sidepanel was open. This specifically occurs for charts sidepanel where we want the stat to update when we select another chart BUT we also want it to stay open when clicking the grid (hence - no active chart left).
However the moment we click on another chart than the first one, then it is supposed to become the new "default" chart.
How to reproduce:
- open the sidepanel of the first chart
- select the second chart
- delete the second chart
=> the sidepanel is still open and falls back on the first chart instead of closing.
Description:
description of this task, what is implemented and why it is implemented that way.
Task: TASK_ID
review checklist
- [ ] feature is organized in plugin, or UI components
- [ ] support of duplicate sheet (deep copy)
- [ ] in model/core: ranges are Range object, and can be adapted (adaptRanges)
- [ ] in model/UI: ranges are strings (to show the user)
- [ ] undo-able commands (uses this.history.update)
- [ ] multiuser-able commands (has inverse commands and transformations where needed)
- [ ] new/updated/removed commands are documented
- [ ] exportable in excel
- [ ] translations (_t("qmsdf %s", abc))
- [ ] unit tested
- [ ] clean commented code
- [ ] track breaking changes
- [ ] doc is rebuild (npm run doc)
- [ ] status is correct in Odoo