odoo/o-spreadsheet#7618
Created by Ronakkumar Mukeshbhai Bharadiya (rmbh)
- label
- odoo:master-fix-grid-overlay-click-icon-rmbh
- head
- a5d01baff791e7600f0a0199de34ac0bcc1298d7
| odoo/o-spreadsheet | |
|---|---|
| master | #7618 missing r+ |
[FIX] grid_overlay: clicking interactive icons should not trigger cell click
Description:
Current behavior before PR:
- Clicking the data validation icon incorrectly triggered the grid onCellClicked handler.
- After the recent change allowing zone deselection on mouseup,
This unintended click caused a recomputation of the selection and closed
the data validation autocomplete popover.
Desired behavior after PR is merged:
- Clicking the icon no longer triggers the grid’s onCellClicked handler.
- This prevents the unnecessary selection recomputation and keeps the
autocomplete popover open during icon interaction.
Task: 5392156
review checklist
- [ ] feature is organized in plugin, or UI components
- [ ] support of duplicate sheet (deep copy)
- [ ] in model/core: ranges are Range object, and can be adapted (adaptRanges)
- [ ] in model/UI: ranges are strings (to show the user)
- [ ] undo-able commands (uses this.history.update)
- [ ] multiuser-able commands (has inverse commands and transformations where needed)
- [ ] new/updated/removed commands are documented
- [ ] exportable in excel
- [ ] translations (_t("qmsdf %s", abc))
- [ ] unit tested
- [ ] clean commented code
- [ ] track breaking changes
- [ ] doc is rebuild (npm run doc)
- [ ] status is correct in Odoo