odoo/o-spreadsheet#8307
Created by Ronakkumar Mukeshbhai Bharadiya (rmbh)
Merged
at 2d269c30e666b363fa95e7179a1e9ae986bf86f2
Statuses:
- label
- odoo:18.0-fix-chart-type-picker-layout-on-hover-rmbh
- head
- 2829b89d7996294e842a4aa3748fd7f53929d083
- merged
- 5 days ago by BI, Adrien Minne (adrm)
| odoo/o-spreadsheet | |
|---|---|
| 18.0 | #8307 |
| saas-18.2 | #8426 |
| saas-18.3 | #8427 |
| saas-18.4 | #8428 |
| 19.0 | #8429 |
| saas-19.1 | #8430 |
| saas-19.2 | #8432 |
| master | #8433 |
[FIX] side_panel: prevent chart picker layout shift on hover
Description:
Current behavior before PR:
- Hovering or selecting a chart type was adding a border while reducing padding to compensate for the size change.
- At non-100% zoom levels, fractional pixel rounding caused inconsistent sizing, leading to layout shifts in the flex container.
- This resulted in chart icons 'dancing' when moving the cursor between them.
Desired behavior after PR is merged:
- A transparent border is applied in the default state to reserve space.
- On hover/selection, only the border color is updated without changing padding.
- This ensures consistent element dimensions and prevents layout shifts across all zoom levels.
Task: 6095239
review checklist
- [ ] feature is organized in plugin, or UI components
- [ ] support of duplicate sheet (deep copy)
- [ ] in model/core: ranges are Range object, and can be adapted (adaptRanges)
- [ ] in model/UI: ranges are strings (to show the user)
- [ ] undo-able commands (uses this.history.update)
- [ ] multiuser-able commands (has inverse commands and transformations where needed)
- [ ] new/updated/removed commands are documented
- [ ] exportable in excel
- [ ] translations (_t("qmsdf %s", abc))
- [ ] unit tested
- [ ] clean commented code
- [ ] track breaking changes
- [ ] doc is rebuild (npm run doc)
- [ ] status is correct in Odoo