odoo/o-spreadsheet#8748
Created by fw-bot
Merged
at c4fa3df1326aa091732869855f5e65269860f595
Statuses:
- label
- odoo:master-saas-19.3-fix-change-chart-type-matho-524268-fw
- head
- c54268d8be9f69308e64236d45f02690e62cf809
- merged
- 4 days ago by BI, Pierre Rousseau (pro)
| odoo/o-spreadsheet | |
|---|---|
| saas-19.3 | #8578 |
| master | #8748 |
[FIX] Chart type: first chart type change resulted in empty chart
Before this commit:
When changing the chart type for the first time, the dataSource in the chart definition was empty, which caused the chart to be empty.
How to reproduce:
1. Create a chart
2. Change the chart type in the side panel from bar to sunburst
3. The chart becomes empty
4. Change again the chart type to bar, the chart is not empty
5. Change again the chart type to sunburst, the chart is not empty
Task: 6197123
review checklist
- [ ] feature is organized in plugin, or UI components
- [ ] support of duplicate sheet (deep copy)
- [ ] in model/core: ranges are Range object, and can be adapted (adaptRanges)
- [ ] in model/UI: ranges are strings (to show the user)
- [ ] undo-able commands (uses this.history.update)
- [ ] multiuser-able commands (has inverse commands and transformations where needed)
- [ ] new/updated/removed commands are documented
- [ ] exportable in excel
- [ ] translations (_t("qmsdf %s", abc))
- [ ] unit tested
- [ ] clean commented code
- [ ] track breaking changes
- [ ] doc is rebuild (npm run doc)
- [ ] status is correct in Odoo
Forward-Port-Of: #8578