odoo/o-spreadsheet#8756
Created by BI, Hendrickx Anthony (anhe)
Merged
at 57e3404e05062eeacd4aa162ada2bcdd28eb4431
Statuses:
- label
- odoo:17.0-formula_fix_iferror_arguments-anhe
- head
- 5e98623929408d47a950c6bb79a47a3c6f9389b8
- merged
- 3 days ago by BI, Pierre Rousseau (pro)
| odoo/o-spreadsheet | |
|---|---|
| 17.0 | #8756 |
| 18.0 | #8758 |
| saas-18.2 | #8760 |
| saas-18.3 | #8761 |
| saas-18.4 | #8762 |
| 19.0 | #8764 |
| saas-19.1 | #8765 |
| saas-19.2 | #8766 |
| saas-19.3 | #8767 |
| master | #8768 |
[FIX] formulas: add IFERROR second argument when exporting data
Description
In our implementation of the IFERROR formula, the second argument (value if error) is optionnal, defaulting to an empty string, which results to a 0 value in the cell when evaluated. In the excel documentation, the second argument of IFERROR is required leading to issue when exporting from spreadsheet a formula with IFERROR and then importing it to excel or Gsheet. This PR fixes this issue by adding a second argument whenn needed in the exporting process.
Related Task
Task: 5993405
review checklist
- [ ] feature is organized in plugin, or UI components
- [ ] support of duplicate sheet (deep copy)
- [ ] in model/core: ranges are Range object, and can be adapted (adaptRanges)
- [ ] in model/UI: ranges are strings (to show the user)
- [ ] undo-able commands (uses this.history.update)
- [ ] multiuser-able commands (has inverse commands and transformations where needed)
- [ ] new/updated/removed commands are documented
- [ ] exportable in excel
- [ ] translations (_t("qmsdf %s", abc))
- [ ] unit tested
- [ ] clean commented code
- [ ] track breaking changes
- [ ] doc is rebuild (npm run doc)
- [ ] status is correct in Odoo