odoo/o-spreadsheet#8994
Created by Ronakkumar Mukeshbhai Bharadiya (rmbh)
- label
- odoo:18.0-fix-nested-backtick-issue-svg-rmbh
- head
- e157f37d2c9d780029e08e97235953830648e34f
| odoo/o-spreadsheet | |
|---|---|
| 18.0 | #8994 missing r+ |
| saas-18.3 | |
| saas-18.4 | |
| 19.0 | |
| saas-19.1 | |
| saas-19.2 | |
| saas-19.3 | |
| saas-19.4 | |
| master |
[FIX] svg: avoid rjsmin issue caused by nested template literals
Description:
Current behavior before PR:
- In Odoo, when debug=assets is disabled, bundles are minified using rjsmin.
- Nested template literals in SVG-related code break CSS output.
- This leads to incorrect rendering and some SVGs not showing.
Desired behavior after PR is merged:
- Removed nested template literals from SVG code.
- Ensures correct CSS generation after minification.
- SVGs now render properly in production.
Task: 6317134
review checklist
- [ ] feature is organized in plugin, or UI components
- [ ] support of duplicate sheet (deep copy)
- [ ] in model/core: ranges are Range object, and can be adapted (adaptRanges)
- [ ] in model/UI: ranges are strings (to show the user)
- [ ] undo-able commands (uses this.history.update)
- [ ] multiuser-able commands (has inverse commands and transformations where needed)
- [ ] new/updated/removed commands are documented
- [ ] exportable in excel
- [ ] translations (_t("qmsdf %s", abc))
- [ ] unit tested
- [ ] clean commented code
- [ ] track breaking changes
- [ ] doc is rebuild (npm run doc)
- [ ] status is correct in Odoo