odoo/odoo#159410

Created by Bugfix, ANSARI MAHAMADASIF (maan)

label

odoo-dev:15.0-sentry-4185609374-boo-not-sub-maan

head

565b77e64a48703fa253160a0855cf5103845581

	odoo/odoo
15.0	#159410

[FIX] web_editor: prevent TypeError while compute image src without checksum

Currently, an error is generated when [1] tries to access the first eight strings of the attachment.checksum but we got False.

Stack Trace:

TypeError: 'bool' object is not subscriptable
  File "odoo/http.py", line 2252, in __call__
    response = request._serve_db()
  File "odoo/http.py", line 1828, in _serve_db
    return self._transactioning(_serve_ir_http, readonly=ro)
  File "odoo/http.py", line 1848, in _transactioning
    return service_model.retrying(func, env=self.env)
  File "odoo/service/model.py", line 134, in retrying
    result = func()
  File "odoo/http.py", line 1826, in _serve_ir_http
    return self._serve_ir_http(rule, args)
  File "odoo/http.py", line 1833, in _serve_ir_http
    response = self.dispatcher.dispatch(rule.endpoint, args)
  File "odoo/http.py", line 2058, in dispatch
    result = self.request.registry['ir.http']._dispatch(endpoint)
  File "odoo/addons/base/models/ir_http.py", line 222, in _dispatch
    result = endpoint(**request.params)
  File "odoo/http.py", line 740, in route_wrapper
    result = endpoint(self, *args, **params_ok)
  File "addons/web_editor/controllers/main.py", line 601, in modify_image
    return attachment.image_src
  File "odoo/fields.py", line 1193, in __get__
    self.compute_value(recs)
  File "odoo/fields.py", line 1375, in compute_value
    records._compute_field_value(self)
  File "odoo/models.py", line 4984, in _compute_field_value
    fields.determine(field.compute, self)
  File "odoo/fields.py", line 102, in determine
    return needle(*args)
  File "addons/web_editor/models/ir_attachment.py", line 53, in _compute_image_src
    unique = attachment.checksum[:8]

This commit will prevent the above issue by indexing the empty string instead of False.

[1]-https://github.com/odoo/odoo/blob/631e2bb1d3f9583200d6fe2f70006397425d5bd2/addons/web_editor/models/ir_attachment.py#L41

sentry-4185609374