odoo/odoo#161831
Created by JavaScript, Om Rabara (omra)
Statuses:
- legal/cla: Contributor License Agreement check
- ci/runbot: Odoo Test Suite
- ci/upgrade_enterprise: Test upgrades for enterprise master
- ci/template: Contact runbot team on discord for help.
- ci/style: Optional style check. Ignore it only if strictly necessary.
- ci/security: Required security check. Can only be ignored by security team.
- ci/documentation: (runtime 481s)
- label
- odoo-dev:16.0-calendar-traceback-fix-omra
- head
- 103e4b9bcd4f7432daf0eee24f20ee41f5718ac6
- merged
- 2 years ago by JavaScript, Aaron Bohy (aab)
| odoo/odoo | |
|---|---|
| 16.0 | #161831 |
| 17.0 | #173783 |
| saas-17.2 | #183811 |
| saas-17.4 | #183905 |
| 18.0 | #184247 |
| saas-18.2 | |
| saas-18.3 | |
| saas-18.4 | |
| 19.0 | |
| saas-19.1 | |
| saas-19.2 | |
| saas-19.3 | |
| master | #186134 |
[FIX] {google, microsoft}_calendar: fix traceback for rapid clicks calendar view
This issue arises when multiple clicks are made on the calendar view button.
Steps to reproduce:
- Install either the google_calendar or microsoft_calendar module.
- Go to calendar > Click multiple times on the calendar view button.
- Error will be generated
This issue specifically occurs if either the google_calendar or microsoft_calendar module has been installed.
this issue occurs because here
https://github.com/odoo/odoo/blob/79666cbab0ab0947b3d853ab58a929635c309bab/addons/google_calendar/static/src/views/google_calendar/google_calendar_model.js#L28 google or microsoft sync will taking longer then 1s, this promise will resolve after 1s and the component is destroyed.
so to address this issue, we need to eliminate the race condition and await the completion of the google/microsoft sync.
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr