odoo/odoo#163337
Created by Website, Quentin Smetz (qsm)
Merged
at 86e5026c550deb292f3c150dedac4294fd0ca1f9
Statuses:
- legal/cla: Contributor License Agreement check
- ci/runbot: Odoo Test Suite
- ci/upgrade_enterprise: Test upgrades for enterprise master
- ci/style: Optional style check. Ignore it only if strictly necessary.
- ci/security: Required security check. Can only be ignored by security team.
- label
- odoo-dev:master-navbar-expand-cls-fix-qsm
- head
- 9b9070014923b5435efa84d25d90d86a4e7da96c
- merged
- 1 year ago by Website, Quentin Smetz (qsm)
| odoo/odoo | |
|---|---|
| master | #163337 |
[FIX] website: allow proper customization of navbar expand classes
Commit 1 introduced a template for the website navbar with a configurable _navbar_expand_class variable... but the variable was acting as a boolean by mistake: if set, it would not set up any class and if not set, it would set the default navbar-expand-lg class.
Meanwhile, a new _navbar_classes variable was introduced allowing customization anyway but it is still worth fixing for consistency. Also, commit 2 and 3 actually used the variable giving it the string "None"... which is just inconsistent and confusing, despite working as intended given the original implementation mistake.
Thanks to imanie383 <manuel@vauxoo.com>
Closes #126489