odoo/odoo#190301

Created by fw-bot
Merged at 2d7f58e08b973dc6d0bff3d6d165fd84f9447bfb

Statuses:

label
odoo-dev:master-16.0-opw-4205826-myhy-7MQQ-fw
head
0112474c89c68db9bc7f34ae01413170986cd152
merged
1 year ago by Mylyna Hy (myhy)
odoo/odoo
16.0 #182545
17.0 #190287
saas-17.2 #190295
saas-17.4 #190299
18.0 #190300
saas-18.2
saas-18.3
saas-18.4
19.0
master #190301

[FW][FIX] website_sale_loyalty: reward points if public user signed a quote

Problem: A loyalty rewards points member don't receive their points for their confirmed order if they don't sign into their account when signing their quotation online from a link they received in their email. This bug only occurs if the quotation is set to "online signature" only. The bug is not reproducible when the quotation is set to both "online signature" and "online payment" or if website_sale_loyalty is not installed.

Purpose: It is expected that customers should receive their reward points for their order without needing to sign in because they accessed the link to sign the quotation from their email. It should be consistent with the behavior exhibited from having "online payment" set for the quotation or without website_sale_loyalty installed.

Steps to Reproduce on Runbot:
1. Install Sales app, website_sale_loyalty, loyalty, sale_loyalty
2. Create a loyalty program that reward points based on orders
3. Create a quotation for a partner, set "online signature" in Other info, and click "Send by email"
4. Access the email in Settings > Technical > Emails
5. Copy the "Accept & sign" link and paste into incognito window
6. Sign the quote as a public user
7. Observe that the loyalty card for the partner did not update the points

opw-4205826


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: #182545