odoo/odoo#191272
Created by fw-bot
Merged
at 04ef13557185ed651f2382a70ca456c221d08cbe
Statuses:
- legal/cla: Contributor License Agreement check
- ci/runbot: Odoo Test Suite
- ci/upgrade_enterprise: Test upgrades for enterprise master
- ci/template: Contact runbot team on discord for help.
- ci/style: Optional style check. Ignore it only if strictly necessary.
- ci/security: Required security check. Can only be ignored by security team.
- label
- odoo-dev:saas-17.2-16.0-opw-4366651-negative_discount-sbel-XAoL-fw
- head
- 2f6259fc74a17d5d4defdc23af7c8c8fdc42087d
- merged
- 9 months ago by Bugfix, Sarah Bellefroid (sbel)
| odoo/odoo | |
|---|---|
| 16.0 | #190785 |
| 17.0 | #191127 |
| saas-17.2 | #191272 |
| saas-17.4 | #191291 |
| 18.0 | #191384 |
| saas-18.1 | #191622 |
| saas-18.2 | |
| saas-18.3 | |
| saas-18.4 | |
| 19.0 | |
| master | #191448 |
[FW][FIX] point_of_sale: not show discount on price manually set
Currently, when using pricelists, if you change the price of a product inside the session, it will show a discount value on the receipt.
Steps to reproduce:
- Activate advanced pricelist
- Modify the shop's default pricelist
- Discount policy: Show public price & discounts
- Add a rule: 10% discount on all products with min qty of 10
- Open shop session
- Add any product qty 1
- Manually change price to a higher amount
- Pay the order
> Observation: On the receipt we can see a negative discount value.
Why the fix:
Changing the price of a product through the price button in the session should never be considered as a discount. Lines for which the product price was manually set should not be counted toward overall discount (positive or negative).