odoo/odoo#192867
Created by Vincent Sevestre (vise)
Statuses:
- legal/cla: Contributor License Agreement check
- ci/runbot: Odoo Test Suite
- ci/upgrade_enterprise: Test upgrades for enterprise master
- ci/template: Contact runbot team on discord for help.
- ci/style: Optional style check. Ignore it only if strictly necessary.
- ci/security: Required security check. Can only be ignored by security team.
- label
- odoo-dev:17.0-iot-logfile-vise
- head
- 47cec4e6cc6d35436eed4d4d5346fb33a9ef7007
- merged
- 9 months ago by POS IoT, Yaroslav Soroko (yaso)
| odoo/odoo | |
|---|---|
| 17.0 | #192867 |
| saas-17.2 | #192922 |
| saas-17.4 | #192976 |
| 18.0 | #192986 |
| saas-18.1 | #194135 |
| saas-18.2 | |
| saas-18.3 | |
| saas-18.4 | |
| 19.0 | |
| master | #194209 |
[FIX] point_of_sale: add default logs location fallback to IoT log do…
…wnload
Current behavior before PR:
When using the "Download logs" button, from the IoT box form view, an Internal Server Error is raised every time.
Internal Server Error : Log file configuration is not set
Description of the issue/feature this PR addresses:
New IoT Box images are missing the default logfile parameter in their config. This parameter is required for log downloading, and cannot be left empty.
The logfile parameter has been removed from the odoo.conf config file in PR #169633. However, it is still explicitly mentioned as /var/log/odoo/odoo-server.log in two other files: https://github.com/odoo/odoo/blob/451a956a22015034b8c35bd0d9a860b78442af7f/addons/hw_posbox_homepage/controllers/homepage.py#L74 and
https://github.com/odoo/odoo/blob/451a956a22015034b8c35bd0d9a860b78442af7f/addons/point_of_sale/tools/posbox/overwrite_before_init/etc/init_posbox_image.sh#L28 As such, a fallback to the default /var/log/odoo/odoo-server.log is added.
Desired behavior after PR is merged:
The Logs can be downloaded from the IoT box form view without receiving an Internal Server Error.
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr