odoo/odoo#201964
Created by fw-bot
Merged
at 4d3b5e933e32f6f14f5d6b29bffed35236402200
Statuses:
- legal/cla: Contributor License Agreement check
- ci/runbot: Odoo Test Suite
- ci/upgrade_enterprise: Test upgrades for enterprise master
- ci/template: Contact runbot team on discord for help.
- ci/style: Optional style check. Ignore it only if strictly necessary.
- ci/security: Required security check. Can only be ignored by security team.
- label
- odoo-dev:saas-18.1-16.0-pg_xact-error-fix-2-wbr-423194-fw
- head
- 469ef497c416905a46fab841cc0c1d0ac7254289
- merged
- 7 months ago by William Braeckman (wbr)
| odoo/odoo | |
|---|---|
| 16.0 | #201401 |
| 17.0 | #201787 |
| saas-17.4 | #201814 |
| 18.0 | #201936 |
| saas-18.1 | #201964 |
| saas-18.2 | #201967 |
| saas-18.3 | |
| saas-18.4 | |
| 19.0 | |
| master | #201974 |
[FW][FIX] odoo: improve pg_xact error mitigation
Initial PR: #194141
It seems the fix above was not enough as it was assumed that connection (or backend in pg terms) were NOT being reused when initiated through sql_db.connect.
For proper cleanup we need to reach this part of the code which can be done in 3 ways:
- calling UNLISTEN * and committing
- closing the connection
- aborting the transaction (before committing the listen)
UNLISTEN * is a good candidate for this, but closing the connection seems to be the safer option.