odoo/odoo#204877
Created by fw-bot
Merged
at c9144695ba53807b771889d031c3470d8191d114
Statuses:
- legal/cla: Contributor License Agreement check
- ci/runbot: Odoo Test Suite
- ci/upgrade_enterprise: Test upgrades for enterprise master
- ci/template: Contact runbot team on discord for help.
- ci/style: Optional style check. Ignore it only if strictly necessary.
- ci/security: Required security check. Can only be ignored by security team.
- label
- odoo-dev:saas-18.2-18.0-opw-4597744-remove_contenteditable_false_file_banner_on_save-wasa-427802-fw
- head
- 9ced7068a8cadea6cea70c88a3cc1d95ba823e43
- merged
- 7 months ago by Walid Sahli (wasa)
| odoo/odoo | |
|---|---|
| 18.0 | #204750 |
| saas-18.1 | #204869 |
| saas-18.2 | #204877 |
| saas-18.3 | |
| saas-18.4 | |
| 19.0 | |
| master | #204885 |
[FW][FIX] html_editor: prevent file boxes from being editable by portal users
Problem:
File boxes contain elements with contenteditable=true. Once saved, portal users can edit them even when the editor is disabled.
Solution:
Use the new mechanism introduced in
69fb021, by adding o-contenteditable-true and o-contenteditable-false classes to file banners.
Steps to reproduce:
1. Navigate to Sales > Product.
2. Open any product.
3. In the Sales tab, add a banner to "Ecommerce Description".
4. Save and click Go to Website.
- Issue: The banner remains editable, even when the editor is disabled.
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: #204750