odoo/upgrade-util#243

Created by Upgrade, Alvaro Fuentes Suarez (afu)

Merged at 0cd78cb408872331fa48b4886264586c250167be

Statuses:

ci/runbot: Test upgrades between stable versions
ci/upgrade_enterprise: Test upgrades for enterprise master

label: odoo-dev:master-fix_rrr2-afu
head: e2dea0ea36010f41b82d094af54a8fadf46ae98b
merged: 2 months ago by Upgrade, Christophe Simonis (chs)

	odoo/upgrade-util
master	#243

[FIX] util/records: deduplicate before batch update

When updating record references we need to dedup uniq indexes. In the case of inderect references the case when two old references become the same new reference was missing.

Example to trigger the issue

test_15=&gt; select * from mail_followers where res_model=&#39;res.partner.bank&#39;
+----+------------------+--------+------------+
| id | res_model        | res_id | partner_id |
|----+------------------+--------+------------|
| 5  | res.partner.bank | 2      | 3          |
| 7  | res.partner.bank | 3      | 3          |
+----+------------------+--------+------------+
test_15=&gt; select id,sanitized_acc_number,partner_id,company_id from res_partner_bank
+----+----------------------+------------+------------+
| id | sanitized_acc_number | partner_id | company_id |
|----+----------------------+------------+------------|
| 1  | 1                    | 3          | 1          |
| 2  | 1                    | 3          | 2          |
| 3  | 1                    | 3          | 3          |
+----+----------------------+------------+------------+

In such case the record replacer will replace references to the partner bank as in the mapping {2:1, 3:1}. But this causes an error

2025-03-07 17:12:12,145 502959 ERROR test_15_16 odoo.sql_db: bad query:

            UPDATE &#34;mail_followers&#34; t
               SET &#34;res_model&#34; = &#39;res.partner.bank&#39;
                   , &#34;res_id&#34; = _upgrade_rrr.new
              FROM _upgrade_rrr
             WHERE &#34;res_model&#34;=&#39;res.partner.bank&#39;
               AND _upgrade_rrr.old = res_id

                    AND
                        NOT EXISTS(SELECT 1 FROM mail_followers WHERE &#34;res_model&#34; = &#39;res.partner.bank&#39; AND &#34;res_id&#34; = _upgrade_rrr.new AND &#34;partner_id&#34;=t.&#34;partner_id&#34;)
                    ;
                DELETE FROM mail_followers USING _upgrade_rrr WHERE &#34;res_model&#34;=&#39;res.partner.bank&#39; AND res_id = _upgrade_rrr.old;

ERROR: duplicate key value violates unique constraint &#34;mail_followers_mail_followers_res_partner_res_model_id_uniq&#34;
DETAIL:  Key (res_model, res_id, partner_id)=(res.partner.bank, 1, 3) already exists.