odoo/o-spreadsheet#3894
Created by BI, Rémi Rahir (rar)
- label
- odoo:saas-16.3-make-FF-great-again-rar
- head
- c443de658aff251ad42eba6234a6aaaa5fe16e71
- target
- saas-16.3
- merged
- 2 months ago by BI, Lucas Lefèvre (lul)
- forward-ports
- odoo/o-spreadsheet#3922 targeting master
- odoo/o-spreadsheet#3921 targeting saas-17.2
- odoo/o-spreadsheet#3920 targeting saas-17.1
- odoo/o-spreadsheet#3919 targeting 17.0
- odoo/o-spreadsheet#3915 targeting saas-16.4
[FIX] BottomBarSheet: Rename a sheet with style content on Firefox
The issue addressed in PR #3351 unfortunately used a `contentEditable` value that is not compatible with Firefox [1]
This revision implements the first strategy explored by the aforementioned PR by removing the full format from the contenteditable span when we stop the edition.
Testing required to define some properties as JSdom does not properly support the implementation of innerText (see [2])
[1]: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/contenteditable#browser_compatibility
[2]: https://github.com/jsdom/jsdom/issues/1245
Task: 3754944
## Description:
description of this task, what is implemented and why it is implemented that way.
Task: : [TASK_ID](https://www.odoo.com/web#id=TASK_ID&action=333&active_id=2328&model=project.task&view_type=form&cids=1&menu_id=4720)
## review checklist
- [ ] feature is organized in plugin, or UI components
- [ ] support of duplicate sheet (deep copy)
- [ ] in model/core: ranges are Range object, and can be adapted (adaptRanges)
- [ ] in model/UI: ranges are strings (to show the user)
- [ ] undo-able commands (uses this.history.update)
- [ ] multiuser-able commands (has inverse commands and transformations where needed)
- [ ] new/updated/removed commands are documented
- [ ] exportable in excel
- [ ] translations (\_t("qmsdf %s", abc))
- [ ] unit tested
- [ ] clean commented code
- [ ] track breaking changes
- [ ] doc is rebuild (npm run doc)
- [ ] status is correct in Odoo