odoo/o-spreadsheet#3920

Created by fw-bot
Merged at 049dd7b7b22128a4709aa9d1cc23b02a9c8f8aa1

Statuses:

label
odoo:saas-17.1-saas-16.3-make-FF-great-again-rar-boPz-fw
head
ee1ae5cf0ec700810d96e77b3a416d546382cc6d
merged
1 year ago by BI, Rémi Rahir (rar)
odoo/o-spreadsheet
saas-16.3 #3894
15.0
saas-16.4 #3915
16.0
17.0 #3919
saas-17.1 #3920
18.0
saas-17.2 #3921
saas-18.1
saas-18.2
saas-18.3
saas-18.4
master #3922

[FW][FIX] BottomBarSheet: Rename a sheet with style content on Firefox

The issue addressed in PR #3351 unfortunately used a contentEditable value that is not compatible with Firefox 1

This revision implements the first strategy explored by the aforementioned PR by removing the full format from the contenteditable span when we stop the edition.

Testing required to define some properties as JSdom does not properly support the implementation of innerText (see 2)

task-3754944

Description:

description of this task, what is implemented and why it is implemented that way.

Task: : TASK_ID

review checklist

  • [ ] feature is organized in plugin, or UI components
  • [ ] support of duplicate sheet (deep copy)
  • [ ] in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • [ ] in model/UI: ranges are strings (to show the user)
  • [ ] undo-able commands (uses this.history.update)
  • [ ] multiuser-able commands (has inverse commands and transformations where needed)
  • [ ] new/updated/removed commands are documented
  • [ ] exportable in excel
  • [ ] translations (_t("qmsdf %s", abc))
  • [ ] unit tested
  • [ ] clean commented code
  • [ ] track breaking changes
  • [ ] doc is rebuild (npm run doc)
  • [ ] status is correct in Odoo

Forward-Port-Of: #3919
Forward-Port-Of: #3894